-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODF actor implemented with Ray Tracing #869
base: master
Are you sure you want to change the base?
Conversation
ODF with texture coeffs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tvcastillod, here are some minor comments on some of these files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tvcastillod!
Overall great work putting up together such a needed actor.
In addition to the changes outlined below, I suggest moving the content of rt_odfs
to ray_tracing/odf
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exciting, thank you for this work @tvcastillod !
First, can you fix the issues from code format CI's and build doc CI's
then, see my first initial comments below.
Question: Can you explain a bit how did you get all this eval_sh_*
?
Hi @skoudoro, The |
This PR aims to create a new odf actor defined with raymarching based on the paper Ray Tracing Spherical Harmonics Glyphs . Work is still in progress.
A visual comparison with the current implementation of fury using polygons
An example is provided showing that it supports displaying multiple glyphs, and with different SH degree.